Implements Sticky and Progress flashes#267
Merged
Conversation
…y flashes, and adds styling for warnings
discorick
changed the title
| } | ||
|
|
||
| .warning { | ||
| background: #f9646e; |
Member
|
I think we're good here. Anything else you want to test, or anything you specifically want me to try out locally? |
Member
Author
|
Just want to do a little bit more testing, just to make sure nothing in the current production logic regressed. |
Member
Author
|
Progress Indicator Flash: Sticky Warning Flash: |
Member
|
I am content. |
?
Member
Author
|
With x for close:
|
Member
Can the x be aligned with the first message row's text? |
Member
Author
|
When the message overflows to an additional row the x starts to look pretty misplaced when its inline. |
Member
What does it look like now? |
Member
Author
|
Can we consider this 'good enough' so I can rebase it into: #278 ? |
Member
👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should give a lot more flexibility in the app over how we handle notifications with the flash component. Gifs below.